Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export is active for share cursor use #1420

Merged
merged 2 commits into from
Feb 24, 2024
Merged

feat: export is active for share cursor use #1420

merged 2 commits into from
Feb 24, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Feb 24, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

@Jocs Jocs marked this pull request as ready for review February 24, 2024 11:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 31.53%. Comparing base (a366a3f) to head (5f115b4).
Report is 4 commits behind head on dev.

Files Patch % Lines
...ocs/src/services/text-selection-manager.service.ts 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #1420   +/-   ##
=======================================
  Coverage   31.53%   31.53%           
=======================================
  Files         859      859           
  Lines       48646    48653    +7     
  Branches    10054    10056    +2     
=======================================
+ Hits        15342    15345    +3     
- Misses      33304    33308    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs merged commit ba51971 into dev Feb 24, 2024
7 checks passed
@Jocs Jocs deleted the feat/export-is-active branch February 24, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikkai jikkai jikkai approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jocs @jikkai